[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 4 08:59:54 PST 2022


mstorsjo added a comment.

In D120982#3360146 <https://reviews.llvm.org/D120982#3360146>, @ldionne wrote:

> After speaking offline with @mstorsjo , I suggest we go ahead with this patch, however we also add a configure-time warning and a release note saying that this behavior is deprecated and will be removed in LLVM 16.

That sounds like a reasonable timeplan to me, and the warning locations sound sensible to me, too. I'll try to amend the patch as suggested and test run it so that it behaves as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982



More information about the libcxx-commits mailing list