[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

[Louis Dionne via Phabricator via libcxx-commits]

ldionne commandeered this revision.
ldionne edited reviewers, added: mstorsjo; removed: ldionne.
ldionne added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:310
     # linked into a shared libcxx; keep dllexport enabled within libcxxabi,
     # as the symbols will need to be exported from libcxx.
   else()
----------------
ldionne wrote:
> Here we can add a hard error if `LIBCXXABI_HERMETIC_STATIC_LIBRARY=ON`, since the two options would contradict one another.
Actually, we can't, because it would start erroring out if someone used `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and the `if()` was satisfied above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982