[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

Fri Mar 4 08:52:06 PST 2022

ldionne added a comment.

After speaking offline with @mstorsjo , I suggest we go ahead with this patch, however we also add a configure-time warning and a release note saying that this behavior is deprecated and will be removed in LLVM 16.

================
Comment at: libcxxabi/CMakeLists.txt:310
     # linked into a shared libcxx; keep dllexport enabled within libcxxabi,
     # as the symbols will need to be exported from libcxx.
   else()
----------------
Here we can add a hard error if `LIBCXXABI_HERMETIC_STATIC_LIBRARY=ON`, since the two options would contradict one another.

================
Comment at: libcxxabi/CMakeLists.txt:313
     # Regular static build; disable dllexports.
     add_definitions(-D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS)
   endif()
----------------
Here we can add a warning if `LIBCXXABI_HERMETIC_STATIC_LIBRARY=OFF` explaining that this behavior is deprecated and will be removed in LLVM 16, asking users to set `LIBCXXABI_HERMETIC_STATIC_LIBRARY=ON` explicitly if they want this configuration.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982