[libcxx-commits] [PATCH] D129925: Tests ignore the return value of sto{meow}, triggering nodiscard warnings in MS STL

Igor Zhukov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 16 10:19:37 PDT 2022


fsb4000 added a comment.

> Do you need me to land it on your behalf?

Yes, thank you for the review on Saturday :)

> For future patches can you prove additional content?

Either by using arcanist or git diff -U999999 main. That makes reviewing a bit easier.

Ok, I will use `git diff -U999999 main`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129925/new/

https://reviews.llvm.org/D129925



More information about the libcxx-commits mailing list