[libcxx-commits] [PATCH] D129925: Tests ignore the return value of sto{meow}, triggering nodiscard warnings in MS STL

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D129925#3657384 <https://reviews.llvm.org/D129925#3657384>, @fsb4000 wrote:

>> Do you need me to land it on your behalf?
>
> Yes, thank you for the review on Saturday :)

You're welcome. I'm a volunteer so Saturday isn't an issue for me ;-)

>> For future patches can you prove additional content?
>> Either by using arcanist or git diff -U999999 main. That makes reviewing a bit easier.
>
> Ok, I will use `git diff -U999999 main`

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129925/new/

https://reviews.llvm.org/D129925