[libcxx-commits] [PATCH] D129925: Tests ignore the return value of sto{meow}, triggering nodiscard warnings in MS STL

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the patch with a MSVC STL style 🐈.
LGTM!
Do you need me to land it on your behalf?



================
Comment at: libcxx/test/std/strings/string.conversions/stod.pass.cpp:60
         {
             size_t idx = 0;
----------------
For future patches can you prove additional content?
Either by using arcanist or `git diff -U999999 main`. That makes reviewing a bit easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129925/new/

https://reviews.llvm.org/D129925