[libcxx-commits] [PATCH] D117962: [libc++] Fix LWG3422 "Issues of seed_seq's constructors"

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 24 11:28:21 PST 2022


Quuxplusone updated this revision to Diff 402612.
Quuxplusone marked 2 inline comments as done.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

Add an `ASSERT_NOEXCEPT`.
Add a .verify.cpp test — but, yuck, it produces an extra error message after the nice one; anything we can/should do about this @ldionne?
Drive-by uglify `init` to `__init`; I don't see where the `init` name came from, and it's private, so I think it's fair game to uglify.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117962/new/

https://reviews.llvm.org/D117962

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/include/__random/seed_seq.h
  libcxx/test/std/numerics/rand/rand.util/rand.util.seedseq/default.pass.cpp
  libcxx/test/std/numerics/rand/rand.util/rand.util.seedseq/iterator.pass.cpp
  libcxx/test/std/numerics/rand/rand.util/rand.util.seedseq/iterator.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117962.402612.patch
Type: text/x-patch
Size: 6467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220124/aea51c63/attachment.bin>


More information about the libcxx-commits mailing list