[libcxx-commits] [PATCH] D117962: [libc++] Fix LWG3422 "Issues of seed_seq's constructors"

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D117962#3267049 <https://reviews.llvm.org/D117962#3267049>, @Quuxplusone wrote:

> Add a .verify.cpp test — but, yuck, it produces an extra error message after the nice one; anything we can/should do about this @ldionne?

Yeah, that's annoying, but I think the solution you have right now is OK. Otherwise, in other places, I've also used something like this:

  // This test checks that we static_assert inside std::atomic<T> when T
  // is not trivially copyable, however Clang will sometimes emit additional
  // errors while trying to instantiate the rest of std::atomic<T>.
  // We silence those to make the test more robust.
  // ADDITIONAL_COMPILE_FLAGS: -Xclang -verify-ignore-unexpected=error

Obviously you'd want to rephrase it not for `atomic`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117962/new/

https://reviews.llvm.org/D117962