[libcxx-commits] [PATCH] D117962: [libc++] Fix LWG3422 "Issues of seed_seq's constructors"

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with suggestions implemented.



================
Comment at: libcxx/include/__random/seed_seq.h:42
     _LIBCPP_INLINE_VISIBILITY
     seed_seq() _NOEXCEPT {}
 #ifndef _LIBCPP_CXX03_LANG
----------------
Are we already testing this noexcept-ness? If not, please add a simple test for that.


================
Comment at: libcxx/include/__random/seed_seq.h:77
 {
+    static_assert(is_integral<typename iterator_traits<_InputIterator>::value_type>::value,
+        "Mandates: iterator_traits<InputIterator>::value_type is an integer type");
----------------
Can we get a libc++ specific `.verify.cpp` test for this diagnostic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117962/new/

https://reviews.llvm.org/D117962