[libcxx-commits] [PATCH] D117962: [libc++] Fix LWG3422 "Issues of seed_seq's constructors"

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__random/seed_seq.h:44
 #ifndef _LIBCPP_CXX03_LANG
-    template<class _Tp>
+    template<class _Tp, __enable_if_t<is_integral<_Tp>::value>* = nullptr>
         _LIBCPP_INLINE_VISIBILITY
----------------
Quuxplusone wrote:
> Mordante wrote:
> > Please include `__nullptr` to make sure this is available.
> Actually this is under `#ifndef _LIBCPP_CXX03_LANG` so it should be fine. (I'm not sure we would `#include <__nullptr>` even if it weren't, but I've raised that tangent over on the Discord.)
Good point. I think it would be good to do it when using C++03. So I retract my comment. So I'm happy with the current state of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117962/new/

https://reviews.llvm.org/D117962