[libcxx-commits] [PATCH] D116809: [libc++] Alphabetize headers, and enforce the order in buildkite. NFCI.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 09:35:43 PST 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/partial_sort_copy.h:19
 #include <__iterator/iterator_traits.h>
-#include <type_traits> // swap
 
----------------
Mordante wrote:
> ldionne wrote:
> > I'll assume this is being included by other headers in `<algorithm>`, and hence is safe to remove.
> I don't see a call to `swap` in this header.
(my comment was referring to the fact that removing transitive includes can break users that don't IWYU properly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116809/new/

https://reviews.llvm.org/D116809



More information about the libcxx-commits mailing list