[libcxx-commits] [PATCH] D116809: [libc++] Alphabetize headers, and enforce the order in buildkite. NFCI.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Nice cleanup!

In D116809#3231248 <https://reviews.llvm.org/D116809#3231248>, @ldionne wrote:

> I don't think we're passing `--check-libcxx-invariants` by default in the CI right now, so the new code in `graph_header_deps.py` isn't being exercised unless I missed something.

I also would like to see it enabled.
I didn't see oddities and the modular build passes, LGTM!



================
Comment at: libcxx/include/__algorithm/partial_sort_copy.h:19
 #include <__iterator/iterator_traits.h>
-#include <type_traits> // swap
 
----------------
ldionne wrote:
> I'll assume this is being included by other headers in `<algorithm>`, and hence is safe to remove.
I don't see a call to `swap` in this header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116809/new/

https://reviews.llvm.org/D116809