[libcxx-commits] [PATCH] D116809: [libc++] Alphabetize headers, and enforce the order in buildkite. NFCI.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 09:50:28 PST 2022


Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.


================
Comment at: libcxx/include/__algorithm/partition.h:15
 #include <__utility/swap.h>
-#include <utility> // pair
 
----------------
ldionne wrote:
> I'll assume this is being included by other headers in `<algorithm>`, and hence is safe to remove.
Yep, `<algorithm>` itself currently contains
```
#include <cstddef>
#include <cstring>
#include <functional>
#include <initializer_list>
#include <iterator>
#include <memory>
#include <type_traits>
#include <utility> // swap_ranges
#include <version>
```
which I think is the correct strategy for Hyrum's Law/IWYU issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116809/new/

https://reviews.llvm.org/D116809



More information about the libcxx-commits mailing list