[libcxx-commits] [PATCH] D116809: [libc++] Alphabetize headers, and enforce the order in buildkite. NFCI.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I don't think we're passing `--check-libcxx-invariants` by default in the CI right now, so the new code in `graph_header_deps.py` isn't being exercised unless I missed something.



================
Comment at: libcxx/include/__algorithm/copy_n.h:16
 #include <__iterator/iterator_traits.h>
-#include <cstring>
 #include <type_traits>
----------------
This collateral removal is safe because that header is included in `copy.h` anyways.


================
Comment at: libcxx/include/__algorithm/partial_sort_copy.h:19
 #include <__iterator/iterator_traits.h>
-#include <type_traits> // swap
 
----------------
I'll assume this is being included by other headers in `<algorithm>`, and hence is safe to remove.


================
Comment at: libcxx/include/__algorithm/partition.h:15
 #include <__utility/swap.h>
-#include <utility> // pair
 
----------------
I'll assume this is being included by other headers in `<algorithm>`, and hence is safe to remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116809/new/

https://reviews.llvm.org/D116809