[libcxx-commits] [PATCH] D119860: [libc++] [test] Mechanically qualify calls to std:: functions. NFCI.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 15 11:14:56 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM assuming this is all indeed just adding `std::`. Did you do it 100% mechanically? Did you make sure that none of these tests is trying to check that we can call some of these functions via ADL? Given the list of functions, that would be unlikely because I don't think any of them guarantees being callable via ADL, but you get the point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119860/new/

https://reviews.llvm.org/D119860



More information about the libcxx-commits mailing list