[libcxx-commits] [PATCH] D119860: [libc++] [test] Mechanically qualify calls to std:: functions. NFCI.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D119860#3323883 <https://reviews.llvm.org/D119860#3323883>, @ldionne wrote:

> LGTM assuming this is all indeed just adding `std::`. Did you do it 100% mechanically? Did you make sure that none of these tests is trying to check that we can call some of these functions via ADL? Given the list of functions, that would be unlikely because I don't think any of them guarantees being callable via ADL, but you get the point.

Yep to all. The only one of these functions where ADL seemed potentially relevant was `std::get`, but the particular user in that case was `libcxx/test/std/ranges/range.utility/range.subrange/ctor.pair_like_conv.pass.cpp` where clearly the ADL-ness wasn't part of the thing being tested.

(I believe that technically the standard requires all of these ADLs to //work//, because the standard shows everything in `namespace std` so it's all one big associated namespace. But I'm sure that //testing// whether ADL works wasn't the point of any of these test cases.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119860/new/

https://reviews.llvm.org/D119860