[libcxx-commits] [PATCH] D119860: [libc++] [test] Mechanically qualify calls to std:: functions. NFCI.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 15 10:08:56 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Following up to D119685 <https://reviews.llvm.org/D119685>, all in one PR to conserve buildkite cycles but to be landed as 9 separate commits just in case:

  8b4bf85dedf5 [libc++] [test] Qualify calls to std::get(tuple). NFCI.
  ce10eef48c53 [libc++] [test] Qualify calls to std::rethrow_exception. NFCI.
  fca25413869d [libc++] [test] Qualify calls to std::atomic_flag_{clear,test} functions. NFCI.
  398771c2a181 [libc++] [test] Qualify calls to std::getline. NFCI.
  1e3e60cc44e1 [libc++] [test] Qualify iomanip functions in std/input.output/iostream.format/. NFCI.
  23cebc56c5d8 [libc++] [test] Qualify calls to iomanip functions in std/localization/. NFCI.
  f528c5c4e64c [libc++] [test] Qualify `prev` as `std::prev` in a lot of tests. NFCI.
  2986d0a23e2e [libc++] [test] Qualify `next` as `std::next` in a lot of tests. NFCI.
  8256cb470412 [libc++] [test] Qualify `move` as `std::move` in a lot of tests. NFCI.

As discussed in D119685 <https://reviews.llvm.org/D119685>, if buildkite is happy with this (which I expect), I'm just going to push it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119860

Files:
  libcxx/test/std/atomics/atomics.flag/atomic_flag_clear.pass.cpp
  libcxx/test/std/atomics/atomics.flag/atomic_flag_clear_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.flag/atomic_flag_test.pass.cpp
  libcxx/test/std/atomics/atomics.flag/atomic_flag_test_and_set.pass.cpp
  libcxx/test/std/atomics/atomics.flag/atomic_flag_test_and_set_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/assign_initializer_list.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/copy.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/copy_alloc.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/copy_assign.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/initializer_list.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/initializer_list_compare.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/initializer_list_compare_alloc.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/iter_iter.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/iter_iter_comp.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/iter_iter_comp_alloc.pass.cpp
  libcxx/test/std/containers/associative/map/map.cons/move.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/emplace.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/emplace_hint.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/erase_iter.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/erase_key.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_cv.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_initializer_list.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_cv.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_rv.pass.cpp
  libcxx/test/std/containers/associative/map/map.modifiers/insert_rv.pass.cpp
  libcxx/test/std/containers/associative/map/map.ops/equal_range.pass.cpp
  libcxx/test/std/containers/associative/map/map.ops/find.pass.cpp
  libcxx/test/std/containers/associative/map/map.ops/lower_bound.pass.cpp
  libcxx/test/std/containers/associative/map/map.ops/upper_bound.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter_comp.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter_comp_alloc.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.cons/move.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/emplace.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/emplace_hint.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_iter.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_key.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_cv.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_cv.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_rv.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_rv.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.ops/equal_range.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.ops/find.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.ops/lower_bound.pass.cpp
  libcxx/test/std/containers/associative/multimap/multimap.ops/upper_bound.pass.cpp
  libcxx/test/std/containers/associative/multiset/emplace.pass.cpp
  libcxx/test/std/containers/associative/multiset/emplace_hint.pass.cpp
  libcxx/test/std/containers/associative/multiset/equal_range.pass.cpp
  libcxx/test/std/containers/associative/multiset/erase_iter.pass.cpp
  libcxx/test/std/containers/associative/multiset/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multiset/erase_key.pass.cpp
  libcxx/test/std/containers/associative/multiset/find.pass.cpp
  libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp
  libcxx/test/std/containers/associative/multiset/insert_iter_cv.pass.cpp
  libcxx/test/std/containers/associative/multiset/insert_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multiset/insert_iter_rv.pass.cpp
  libcxx/test/std/containers/associative/multiset/insert_rv.pass.cpp
  libcxx/test/std/containers/associative/multiset/lower_bound.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/copy.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/copy_alloc.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/copy_assign.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter_alloc.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter_comp.pass.cpp
  libcxx/test/std/containers/associative/multiset/multiset.cons/move.pass.cpp
  libcxx/test/std/containers/associative/multiset/upper_bound.pass.cpp
  libcxx/test/std/containers/associative/set/emplace.pass.cpp
  libcxx/test/std/containers/associative/set/emplace_hint.pass.cpp
  libcxx/test/std/containers/associative/set/equal_range.pass.cpp
  libcxx/test/std/containers/associative/set/erase_iter.pass.cpp
  libcxx/test/std/containers/associative/set/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/set/erase_key.pass.cpp
  libcxx/test/std/containers/associative/set/find.pass.cpp
  libcxx/test/std/containers/associative/set/insert_cv.pass.cpp
  libcxx/test/std/containers/associative/set/insert_iter_cv.pass.cpp
  libcxx/test/std/containers/associative/set/insert_iter_iter.pass.cpp
  libcxx/test/std/containers/associative/set/insert_iter_rv.pass.cpp
  libcxx/test/std/containers/associative/set/insert_rv.pass.cpp
  libcxx/test/std/containers/associative/set/lower_bound.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/copy.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/copy_alloc.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/copy_assign.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/iter_iter.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/iter_iter_alloc.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/iter_iter_comp.pass.cpp
  libcxx/test/std/containers/associative/set/set.cons/move.pass.cpp
  libcxx/test/std/containers/associative/set/upper_bound.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/emplace_after.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/emplace_front.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/erase_after_many.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/erase_after_one.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_const.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_init.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_range.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_rv.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_size_value.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_const.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_rv.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size_value.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_flist.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_one.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_range.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.spec/member_swap.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.spec/non_member_swap.pass.cpp
  libcxx/test/std/containers/sequences/list/list.modifiers/erase_iter.pass.cpp
  libcxx/test/std/containers/sequences/list/list.modifiers/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_initializer_list.pass.cpp
  libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_size_value.pass.cpp
  libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_value.pass.cpp
  libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list.pass.cpp
  libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list_iter.pass.cpp
  libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list_iter_iter.pass.cpp
  libcxx/test/std/containers/sequences/vector.bool/erase_iter.pass.cpp
  libcxx/test/std/containers/sequences/vector.bool/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter_iter.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_range.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/reserve.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/swap_member.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/emplace_hint.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_range.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_range.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_range.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.manip/ws.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/bool.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/double.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/float.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/int.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long_double.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/short.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_int.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_long_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_short.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/signed_char.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/signed_char_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/unsigned_char.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/unsigned_char_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/endl.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/ends.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/flush.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/move.pass.cpp
  libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
  libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
  libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_en_US.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_string_en_US.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_en_US.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_fr_FR.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_string_en_US.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_bool.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_bool.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_int.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long_long.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_short.pass.cpp
  libcxx/test/std/ranges/range.utility/range.subrange/ctor.pair_like_conv.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_delim.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_delim_rv.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_rv.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/char_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/pointer_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_string.pass.cpp



More information about the libcxx-commits mailing list