[libcxx-commits] [libcxx] bbb0f2c - [libc++] Replace `#include ""` with `<>` in libcxx/src/. NFCI.
Arthur O'Dwyer via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 15 10:01:21 PST 2022
Author: Arthur O'Dwyer
Date: 2022-02-15T13:00:46-05:00
New Revision: bbb0f2c759a16f2fb4e1d74795b790cf0c170620
URL: https://github.com/llvm/llvm-project/commit/bbb0f2c759a16f2fb4e1d74795b790cf0c170620
DIFF: https://github.com/llvm/llvm-project/commit/bbb0f2c759a16f2fb4e1d74795b790cf0c170620.diff
LOG: [libc++] Replace `#include ""` with `<>` in libcxx/src/. NFCI.
Our best guess is that the two syntaxes should have exactly equivalent
effects, so, let's be consistent with what we do in libcxx/include/.
I've left `#include "include/x.h"` and `#include "../y.h"` alone
because I'm less sure that they're interchangeable, and they aren't
inconsistent with libcxx/include/ because libcxx/include/ never
does that kind of thing.
Also, use the `_LIBCPP_PUSH_MACROS/POP_MACROS` dance for `<__undef_macros>`,
even though it's technically unnecessary in a standalone .cpp file,
just so we have consistently one way to do it.
Differential Revision: https://reviews.llvm.org/D119561
Added:
Modified:
libcxx/src/algorithm.cpp
libcxx/src/any.cpp
libcxx/src/bind.cpp
libcxx/src/charconv.cpp
libcxx/src/chrono.cpp
libcxx/src/condition_variable.cpp
libcxx/src/condition_variable_destructor.cpp
libcxx/src/debug.cpp
libcxx/src/exception.cpp
libcxx/src/experimental/memory_resource.cpp
libcxx/src/filesystem/directory_iterator.cpp
libcxx/src/filesystem/filesystem_common.h
libcxx/src/filesystem/int128_builtins.cpp
libcxx/src/filesystem/operations.cpp
libcxx/src/filesystem/posix_compat.h
libcxx/src/format.cpp
libcxx/src/functional.cpp
libcxx/src/future.cpp
libcxx/src/hash.cpp
libcxx/src/include/atomic_support.h
libcxx/src/include/ryu/d2fixed.h
libcxx/src/include/ryu/d2fixed_full_table.h
libcxx/src/include/ryu/d2s.h
libcxx/src/include/ryu/d2s_full_table.h
libcxx/src/include/ryu/d2s_intrinsics.h
libcxx/src/include/ryu/digit_table.h
libcxx/src/include/ryu/f2s.h
libcxx/src/include/ryu/ryu.h
libcxx/src/include/to_chars_floating_point.h
libcxx/src/ios.cpp
libcxx/src/ios.instantiations.cpp
libcxx/src/iostream.cpp
libcxx/src/legacy_pointer_safety.cpp
libcxx/src/locale.cpp
libcxx/src/memory.cpp
libcxx/src/mutex.cpp
libcxx/src/mutex_destructor.cpp
libcxx/src/new.cpp
libcxx/src/optional.cpp
libcxx/src/random.cpp
libcxx/src/random_shuffle.cpp
libcxx/src/regex.cpp
libcxx/src/ryu/d2fixed.cpp
libcxx/src/ryu/d2s.cpp
libcxx/src/ryu/f2s.cpp
libcxx/src/shared_mutex.cpp
libcxx/src/stdexcept.cpp
libcxx/src/string.cpp
libcxx/src/strstream.cpp
libcxx/src/system_error.cpp
libcxx/src/thread.cpp
libcxx/src/typeinfo.cpp
libcxx/src/utility.cpp
libcxx/src/valarray.cpp
libcxx/src/variant.cpp
libcxx/src/vector.cpp
Removed:
################################################################################
diff --git a/libcxx/src/algorithm.cpp b/libcxx/src/algorithm.cpp
index 4cc7c2725aa06..decc8419fa833 100644
--- a/libcxx/src/algorithm.cpp
+++ b/libcxx/src/algorithm.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "algorithm"
+#include <algorithm>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/any.cpp b/libcxx/src/any.cpp
index 2939fe2996978..9a101b44a71a8 100644
--- a/libcxx/src/any.cpp
+++ b/libcxx/src/any.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "any"
+#include <any>
namespace std {
const char* bad_any_cast::what() const noexcept {
diff --git a/libcxx/src/bind.cpp b/libcxx/src/bind.cpp
index a54df2c0dd7e9..0e217e5fc5d65 100644
--- a/libcxx/src/bind.cpp
+++ b/libcxx/src/bind.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "functional"
+#include <functional>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/charconv.cpp b/libcxx/src/charconv.cpp
index 60ec3eccc949d..9537b42de7fc3 100644
--- a/libcxx/src/charconv.cpp
+++ b/libcxx/src/charconv.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "charconv"
+#include <charconv>
#include <string.h>
#include "include/ryu/digit_table.h"
diff --git a/libcxx/src/chrono.cpp b/libcxx/src/chrono.cpp
index 4f2d51042ff10..0af89d6a526c4 100644
--- a/libcxx/src/chrono.cpp
+++ b/libcxx/src/chrono.cpp
@@ -12,9 +12,9 @@
#define _LARGE_TIME_API
#endif
-#include "chrono"
-#include "cerrno" // errno
-#include "system_error" // __throw_system_error
+#include <cerrno> // errno
+#include <chrono>
+#include <system_error> // __throw_system_error
#if defined(__MVS__)
#include <__support/ibm/gettod_zos.h> // gettimeofdayMonotonic
diff --git a/libcxx/src/condition_variable.cpp b/libcxx/src/condition_variable.cpp
index 0ade56b484328..b17c4cf6458e1 100644
--- a/libcxx/src/condition_variable.cpp
+++ b/libcxx/src/condition_variable.cpp
@@ -6,19 +6,21 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
+#include <__config>
#ifndef _LIBCPP_HAS_NO_THREADS
-#include "condition_variable"
-#include "thread"
-#include "system_error"
-#include "__undef_macros"
+#include <condition_variable>
+#include <thread>
+#include <system_error>
#if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-#pragma comment(lib, "pthread")
+# pragma comment(lib, "pthread")
#endif
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
_LIBCPP_BEGIN_NAMESPACE_STD
// ~condition_variable is defined elsewhere.
@@ -90,4 +92,6 @@ notify_all_at_thread_exit(condition_variable& cond, unique_lock<mutex> lk)
_LIBCPP_END_NAMESPACE_STD
+_LIBCPP_POP_MACROS
+
#endif // !_LIBCPP_HAS_NO_THREADS
diff --git a/libcxx/src/condition_variable_destructor.cpp b/libcxx/src/condition_variable_destructor.cpp
index 350e6b77f244a..c217a09394fcb 100644
--- a/libcxx/src/condition_variable_destructor.cpp
+++ b/libcxx/src/condition_variable_destructor.cpp
@@ -11,8 +11,8 @@
// On some platforms ~condition_variable has been made trivial and the
// definition is only provided for ABI compatibility.
-#include "__config"
-#include "__threading_support"
+#include <__config>
+#include <__threading_support>
#if !defined(_LIBCPP_HAS_NO_THREADS)
# if _LIBCPP_ABI_VERSION == 1 || !defined(_LIBCPP_HAS_TRIVIAL_CONDVAR_DESTRUCTION)
diff --git a/libcxx/src/debug.cpp b/libcxx/src/debug.cpp
index 15d8fdb8816ba..14a75b10f742e 100644
--- a/libcxx/src/debug.cpp
+++ b/libcxx/src/debug.cpp
@@ -6,18 +6,19 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
-#include "__debug"
-#include "functional"
-#include "algorithm"
-#include "string"
-#include "cstdio"
-#include "__hash_table"
+#include <__config>
+#include <__debug>
+#include <__hash_table>
+#include <algorithm>
+#include <cstdio>
+#include <functional>
+#include <string>
+
#ifndef _LIBCPP_HAS_NO_THREADS
-#include "mutex"
-#if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-#pragma comment(lib, "pthread")
-#endif
+# include <mutex>
+# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
+# pragma comment(lib, "pthread")
+# endif
#endif
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/exception.cpp b/libcxx/src/exception.cpp
index efb56c15e7933..e5d6b9e73a267 100644
--- a/libcxx/src/exception.cpp
+++ b/libcxx/src/exception.cpp
@@ -6,9 +6,9 @@
//
//===----------------------------------------------------------------------===//
-#include "exception"
-#include "new"
-#include "typeinfo"
+#include <exception>
+#include <new>
+#include <typeinfo>
#if defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI)
#include <cxxabi.h>
diff --git a/libcxx/src/experimental/memory_resource.cpp b/libcxx/src/experimental/memory_resource.cpp
index af86079823b69..e9fb5b59045c5 100644
--- a/libcxx/src/experimental/memory_resource.cpp
+++ b/libcxx/src/experimental/memory_resource.cpp
@@ -6,15 +6,15 @@
//
//===----------------------------------------------------------------------===//
-#include "experimental/memory_resource"
+#include <experimental/memory_resource>
#ifndef _LIBCPP_HAS_NO_ATOMIC_HEADER
-#include "atomic"
+# include <atomic>
#elif !defined(_LIBCPP_HAS_NO_THREADS)
-#include "mutex"
-#if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-#pragma comment(lib, "pthread")
-#endif
+# include <mutex>
+# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
+# pragma comment(lib, "pthread")
+# endif
#endif
_LIBCPP_BEGIN_NAMESPACE_LFTS_PMR
diff --git a/libcxx/src/filesystem/directory_iterator.cpp b/libcxx/src/filesystem/directory_iterator.cpp
index fa793f68295b6..c9294f7a328bb 100644
--- a/libcxx/src/filesystem/directory_iterator.cpp
+++ b/libcxx/src/filesystem/directory_iterator.cpp
@@ -6,10 +6,10 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
-#include "filesystem"
-#include "stack"
+#include <__config>
#include <errno.h>
+#include <filesystem>
+#include <stack>
#include "filesystem_common.h"
diff --git a/libcxx/src/filesystem/filesystem_common.h b/libcxx/src/filesystem/filesystem_common.h
index 211b77834c9fc..94153567b8110 100644
--- a/libcxx/src/filesystem/filesystem_common.h
+++ b/libcxx/src/filesystem/filesystem_common.h
@@ -9,15 +9,15 @@
#ifndef FILESYSTEM_COMMON_H
#define FILESYSTEM_COMMON_H
-#include "__config"
-#include "array"
-#include "chrono"
-#include "climits"
-#include "cstdarg"
-#include "ctime"
-#include "filesystem"
-#include "ratio"
-#include "system_error"
+#include <__config>
+#include <array>
+#include <chrono>
+#include <climits>
+#include <cstdarg>
+#include <ctime>
+#include <filesystem>
+#include <ratio>
+#include <system_error>
#include <utility>
#if defined(_LIBCPP_WIN32API)
diff --git a/libcxx/src/filesystem/int128_builtins.cpp b/libcxx/src/filesystem/int128_builtins.cpp
index ed531ee145a21..f003da27a74d0 100644
--- a/libcxx/src/filesystem/int128_builtins.cpp
+++ b/libcxx/src/filesystem/int128_builtins.cpp
@@ -13,8 +13,8 @@
*
* ===----------------------------------------------------------------------===
*/
-#include "__config"
-#include "climits"
+#include <__config>
+#include <climits>
#if !defined(_LIBCPP_HAS_NO_INT128)
diff --git a/libcxx/src/filesystem/operations.cpp b/libcxx/src/filesystem/operations.cpp
index 244cc9837f9f7..57e25397a28c8 100644
--- a/libcxx/src/filesystem/operations.cpp
+++ b/libcxx/src/filesystem/operations.cpp
@@ -7,14 +7,14 @@
//===----------------------------------------------------------------------===//
#include <__utility/unreachable.h>
-#include "filesystem"
-#include "array"
-#include "iterator"
-#include "string_view"
-#include "type_traits"
-#include "vector"
-#include "cstdlib"
-#include "climits"
+#include <array>
+#include <climits>
+#include <cstdlib>
+#include <filesystem>
+#include <iterator>
+#include <string_view>
+#include <type_traits>
+#include <vector>
#include "filesystem_common.h"
@@ -40,7 +40,7 @@
# include <copyfile.h>
# define _LIBCPP_FILESYSTEM_USE_COPYFILE
#else
-# include "fstream"
+# include <fstream>
# define _LIBCPP_FILESYSTEM_USE_FSTREAM
#endif
diff --git a/libcxx/src/filesystem/posix_compat.h b/libcxx/src/filesystem/posix_compat.h
index f5c8ec39df2b2..6cd6650081614 100644
--- a/libcxx/src/filesystem/posix_compat.h
+++ b/libcxx/src/filesystem/posix_compat.h
@@ -23,7 +23,7 @@
#ifndef POSIX_COMPAT_H
#define POSIX_COMPAT_H
-#include "filesystem"
+#include <filesystem>
#include "filesystem_common.h"
diff --git a/libcxx/src/format.cpp b/libcxx/src/format.cpp
index 2ebec28247e64..cdbcbf8b058d2 100644
--- a/libcxx/src/format.cpp
+++ b/libcxx/src/format.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "format"
+#include <format>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/functional.cpp b/libcxx/src/functional.cpp
index d8cfaa70337f7..ca1079cdd88de 100644
--- a/libcxx/src/functional.cpp
+++ b/libcxx/src/functional.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "functional"
+#include <functional>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/future.cpp b/libcxx/src/future.cpp
index 07ae9389ec238..cdaa93827533d 100644
--- a/libcxx/src/future.cpp
+++ b/libcxx/src/future.cpp
@@ -6,12 +6,12 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
+#include <__config>
#ifndef _LIBCPP_HAS_NO_THREADS
-#include "future"
-#include "string"
+#include <future>
+#include <string>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/hash.cpp b/libcxx/src/hash.cpp
index daf276f5b7d26..96cbd38f4dd84 100644
--- a/libcxx/src/hash.cpp
+++ b/libcxx/src/hash.cpp
@@ -6,10 +6,10 @@
//
//===----------------------------------------------------------------------===//
-#include "__hash_table"
-#include "algorithm"
-#include "stdexcept"
-#include "type_traits"
+#include <__hash_table>
+#include <algorithm>
+#include <stdexcept>
+#include <type_traits>
_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wtautological-constant-out-of-range-compare")
diff --git a/libcxx/src/include/atomic_support.h b/libcxx/src/include/atomic_support.h
index 5a745a2f0091c..3e73f2ce27f39 100644
--- a/libcxx/src/include/atomic_support.h
+++ b/libcxx/src/include/atomic_support.h
@@ -9,8 +9,8 @@
#ifndef ATOMIC_SUPPORT_H
#define ATOMIC_SUPPORT_H
-#include "__config"
-#include "memory" // for __libcpp_relaxed_load
+#include <__config>
+#include <memory> // for __libcpp_relaxed_load
#if defined(__clang__) && __has_builtin(__atomic_load_n) \
&& __has_builtin(__atomic_store_n) \
diff --git a/libcxx/src/include/ryu/d2fixed.h b/libcxx/src/include/ryu/d2fixed.h
index e495c11b1d4f2..b8862de251ce5 100644
--- a/libcxx/src/include/ryu/d2fixed.h
+++ b/libcxx/src/include/ryu/d2fixed.h
@@ -42,8 +42,8 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
-#include "cstdint"
+#include <__config>
+#include <cstdint>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/d2fixed_full_table.h b/libcxx/src/include/ryu/d2fixed_full_table.h
index 7181cd8cf6e26..a63d6f2d16193 100644
--- a/libcxx/src/include/ryu/d2fixed_full_table.h
+++ b/libcxx/src/include/ryu/d2fixed_full_table.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/d2s.h b/libcxx/src/include/ryu/d2s.h
index 15d50fd1ee543..3d9f10c0f15a3 100644
--- a/libcxx/src/include/ryu/d2s.h
+++ b/libcxx/src/include/ryu/d2s.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/d2s_full_table.h b/libcxx/src/include/ryu/d2s_full_table.h
index 106fef0015c18..96307f6986278 100644
--- a/libcxx/src/include/ryu/d2s_full_table.h
+++ b/libcxx/src/include/ryu/d2s_full_table.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/d2s_intrinsics.h b/libcxx/src/include/ryu/d2s_intrinsics.h
index 95912818ac97f..093d8580774b5 100644
--- a/libcxx/src/include/ryu/d2s_intrinsics.h
+++ b/libcxx/src/include/ryu/d2s_intrinsics.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
#include "include/ryu/ryu.h"
diff --git a/libcxx/src/include/ryu/digit_table.h b/libcxx/src/include/ryu/digit_table.h
index 3962f66931400..e4ee94ce26cba 100644
--- a/libcxx/src/include/ryu/digit_table.h
+++ b/libcxx/src/include/ryu/digit_table.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/f2s.h b/libcxx/src/include/ryu/f2s.h
index 80fdcd458b728..be304c2f9c63e 100644
--- a/libcxx/src/include/ryu/f2s.h
+++ b/libcxx/src/include/ryu/f2s.h
@@ -42,7 +42,7 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
+#include <__config>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/include/ryu/ryu.h b/libcxx/src/include/ryu/ryu.h
index 04d4f2c04191d..cb44bd3fef058 100644
--- a/libcxx/src/include/ryu/ryu.h
+++ b/libcxx/src/include/ryu/ryu.h
@@ -44,14 +44,15 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__charconv/chars_format.h"
-#include "__charconv/to_chars_result.h"
-#include "__config"
-#include "__debug"
-#include "__errc"
-#include "cstdint"
-#include "cstring"
-#include "type_traits"
+#include <__charconv/chars_format.h>
+#include <__charconv/to_chars_result.h>
+#include <__config>
+#include <__debug>
+#include <__errc>
+#include <cstdint>
+#include <cstring>
+#include <type_traits>
+
#include "include/ryu/f2s.h"
#include "include/ryu/d2s.h"
#include "include/ryu/d2fixed.h"
diff --git a/libcxx/src/include/to_chars_floating_point.h b/libcxx/src/include/to_chars_floating_point.h
index 081d671fc59e7..3f8d3613d8bdc 100644
--- a/libcxx/src/include/to_chars_floating_point.h
+++ b/libcxx/src/include/to_chars_floating_point.h
@@ -17,16 +17,17 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__algorithm/find.h"
-#include "__algorithm/find_if.h"
-#include "__algorithm/lower_bound.h"
-#include "__algorithm/min.h"
-#include "__config"
-#include "__iterator/access.h"
-#include "__iterator/size.h"
-#include "bit"
-#include "cfloat"
-#include "climits"
+#include <__algorithm/find.h>
+#include <__algorithm/find_if.h>
+#include <__algorithm/lower_bound.h>
+#include <__algorithm/min.h>
+#include <__config>
+#include <__iterator/access.h>
+#include <__iterator/size.h>
+#include <bit>
+#include <cfloat>
+#include <climits>
+
#include "include/ryu/ryu.h"
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/ios.cpp b/libcxx/src/ios.cpp
index 56fbcca417aa7..218b27f1a6b50 100644
--- a/libcxx/src/ios.cpp
+++ b/libcxx/src/ios.cpp
@@ -6,20 +6,20 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
-
-#include "ios"
-
+#include <__config>
+#include <__locale>
+#include <algorithm>
+#include <ios>
+#include <limits>
+#include <memory>
+#include <new>
#include <stdlib.h>
+#include <string>
-#include "__locale"
-#include "algorithm"
#include "include/config_elast.h"
-#include "limits"
-#include "memory"
-#include "new"
-#include "string"
-#include "__undef_macros"
+
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
_LIBCPP_BEGIN_NAMESPACE_STD
@@ -439,3 +439,5 @@ ios_base::sync_with_stdio(bool sync)
}
_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
diff --git a/libcxx/src/ios.instantiations.cpp b/libcxx/src/ios.instantiations.cpp
index e1189d0b5bd97..2ff7057fa66a4 100644
--- a/libcxx/src/ios.instantiations.cpp
+++ b/libcxx/src/ios.instantiations.cpp
@@ -6,14 +6,13 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
-#include "fstream"
-#include "ios"
-#include "istream"
-#include "ostream"
-#include "sstream"
-#include "streambuf"
-
+#include <__config>
+#include <fstream>
+#include <ios>
+#include <istream>
+#include <ostream>
+#include <sstream>
+#include <streambuf>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/iostream.cpp b/libcxx/src/iostream.cpp
index d87bf7af84ba8..6164fd7a525ed 100644
--- a/libcxx/src/iostream.cpp
+++ b/libcxx/src/iostream.cpp
@@ -6,10 +6,10 @@
//
//===----------------------------------------------------------------------===//
-#include "__std_stream"
-#include "__locale"
-#include "string"
-#include "new"
+#include <__locale>
+#include <__std_stream>
+#include <new>
+#include <string>
#define _str(s) #s
#define str(s) _str(s)
diff --git a/libcxx/src/legacy_pointer_safety.cpp b/libcxx/src/legacy_pointer_safety.cpp
index 34f5613ae2539..5d2b04c121ae6 100644
--- a/libcxx/src/legacy_pointer_safety.cpp
+++ b/libcxx/src/legacy_pointer_safety.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
+#include <__config>
#include <memory>
// Support for garbage collection was removed in C++23 by https://wg21.link/P2186R2. Libc++ implements
diff --git a/libcxx/src/locale.cpp b/libcxx/src/locale.cpp
index a45dcbf2d8dd8..bd3f8733f57c4 100644
--- a/libcxx/src/locale.cpp
+++ b/libcxx/src/locale.cpp
@@ -13,20 +13,20 @@
#endif
#include <__utility/unreachable.h>
-#include "algorithm"
-#include "clocale"
-#include "codecvt"
-#include "cstdio"
-#include "cstdlib"
-#include "cstring"
-#include "locale"
-#include "string"
-#include "type_traits"
-#include "typeinfo"
-#include "vector"
+#include <algorithm>
+#include <clocale>
+#include <codecvt>
+#include <cstdio>
+#include <cstdlib>
+#include <cstring>
+#include <locale>
+#include <string>
+#include <type_traits>
+#include <typeinfo>
+#include <vector>
#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
-# include "cwctype"
+# include <cwctype>
#endif
#if defined(_AIX)
@@ -45,12 +45,14 @@
#include "include/atomic_support.h"
#include "include/sso_allocator.h"
-#include "__undef_macros"
// On Linux, wint_t and wchar_t have
diff erent signed-ness, and this causes
// lots of noise in the build log, but no bugs that I know of.
_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wsign-conversion")
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
_LIBCPP_BEGIN_NAMESPACE_STD
struct __libcpp_unique_locale {
@@ -6587,3 +6589,5 @@ template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS codecvt_byname<char32_t,
#endif
_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
diff --git a/libcxx/src/memory.cpp b/libcxx/src/memory.cpp
index e998e97b65270..1b8c6b7e80fc3 100644
--- a/libcxx/src/memory.cpp
+++ b/libcxx/src/memory.cpp
@@ -6,14 +6,16 @@
//
//===----------------------------------------------------------------------===//
-#include "memory"
+#include <memory>
+
#ifndef _LIBCPP_HAS_NO_THREADS
-# include "mutex"
-# include "thread"
-# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-# pragma comment(lib, "pthread")
-# endif
+# include <mutex>
+# include <thread>
+# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
+# pragma comment(lib, "pthread")
+# endif
#endif
+
#include "include/atomic_support.h"
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/mutex.cpp b/libcxx/src/mutex.cpp
index 6669e76981682..9e780aaff64e8 100644
--- a/libcxx/src/mutex.cpp
+++ b/libcxx/src/mutex.cpp
@@ -6,19 +6,23 @@
//
//===----------------------------------------------------------------------===//
-#include "mutex"
-#include "limits"
-#include "system_error"
+#include <limits>
+#include <mutex>
+#include <system_error>
+
#include "include/atomic_support.h"
-#include "__undef_macros"
#ifndef _LIBCPP_HAS_NO_THREADS
-#if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-#pragma comment(lib, "pthread")
-#endif
+# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
+# pragma comment(lib, "pthread")
+# endif
#endif
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
_LIBCPP_BEGIN_NAMESPACE_STD
+
#ifndef _LIBCPP_HAS_NO_THREADS
const defer_lock_t defer_lock{};
@@ -258,3 +262,5 @@ void __call_once(volatile once_flag::_State_type& flag, void* arg,
}
_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
diff --git a/libcxx/src/mutex_destructor.cpp b/libcxx/src/mutex_destructor.cpp
index e8b1e42dd54c3..6850b6e6f4950 100644
--- a/libcxx/src/mutex_destructor.cpp
+++ b/libcxx/src/mutex_destructor.cpp
@@ -16,13 +16,13 @@
// we re-declare the entire class in this file instead of using
// _LIBCPP_BUILDING_LIBRARY to change the definition in the headers.
-#include "__config"
-#include "__threading_support"
+#include <__config>
+#include <__threading_support>
#if !defined(_LIBCPP_HAS_NO_THREADS)
-#if _LIBCPP_ABI_VERSION == 1 || !defined(_LIBCPP_HAS_TRIVIAL_MUTEX_DESTRUCTION)
-#define NEEDS_MUTEX_DESTRUCTOR
-#endif
+# if _LIBCPP_ABI_VERSION == 1 || !defined(_LIBCPP_HAS_TRIVIAL_MUTEX_DESTRUCTION)
+# define NEEDS_MUTEX_DESTRUCTOR
+# endif
#endif
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/new.cpp b/libcxx/src/new.cpp
index 0a9bee4e39a41..48d6f997fdda4 100644
--- a/libcxx/src/new.cpp
+++ b/libcxx/src/new.cpp
@@ -6,9 +6,9 @@
//
//===----------------------------------------------------------------------===//
+#include <new>
#include <stdlib.h>
-#include "new"
#include "include/atomic_support.h"
#if defined(_LIBCPP_ABI_MICROSOFT)
diff --git a/libcxx/src/optional.cpp b/libcxx/src/optional.cpp
index 251ebe2e6826a..ac1a0a5b5e883 100644
--- a/libcxx/src/optional.cpp
+++ b/libcxx/src/optional.cpp
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#include "optional"
-#include "__availability"
+#include <__availability>
+#include <optional>
namespace std
{
diff --git a/libcxx/src/random.cpp b/libcxx/src/random.cpp
index 6472a8dbcba3e..466b0157722f3 100644
--- a/libcxx/src/random.cpp
+++ b/libcxx/src/random.cpp
@@ -13,9 +13,9 @@
# define _CRT_RAND_S
#endif // defined(_LIBCPP_USING_WIN32_RANDOM)
-#include "limits"
-#include "random"
-#include "system_error"
+#include <limits>
+#include <random>
+#include <system_error>
#if defined(__sun__)
# define rename solaris_headers_are_broken
diff --git a/libcxx/src/random_shuffle.cpp b/libcxx/src/random_shuffle.cpp
index 753a15f91daa0..e9087a97014f7 100644
--- a/libcxx/src/random_shuffle.cpp
+++ b/libcxx/src/random_shuffle.cpp
@@ -6,13 +6,14 @@
//
//===----------------------------------------------------------------------===//
-#include "algorithm"
-#include "random"
+#include <algorithm>
+#include <random>
+
#ifndef _LIBCPP_HAS_NO_THREADS
-# include "mutex"
-# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-# pragma comment(lib, "pthread")
-# endif
+# include <mutex>
+# if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
+# pragma comment(lib, "pthread")
+# endif
#endif
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/regex.cpp b/libcxx/src/regex.cpp
index 16ad8f0effdb0..e53d324186900 100644
--- a/libcxx/src/regex.cpp
+++ b/libcxx/src/regex.cpp
@@ -6,9 +6,9 @@
//
//===----------------------------------------------------------------------===//
-#include "regex"
-#include "algorithm"
-#include "iterator"
+#include <algorithm>
+#include <iterator>
+#include <regex>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/ryu/d2fixed.cpp b/libcxx/src/ryu/d2fixed.cpp
index 699f9158f4c36..bb6d621803616 100644
--- a/libcxx/src/ryu/d2fixed.cpp
+++ b/libcxx/src/ryu/d2fixed.cpp
@@ -39,10 +39,10 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
-#include "charconv"
-#include "cstring"
-#include "system_error"
+#include <__config>
+#include <charconv>
+#include <cstring>
+#include <system_error>
#include "include/ryu/common.h"
#include "include/ryu/d2fixed.h"
diff --git a/libcxx/src/ryu/d2s.cpp b/libcxx/src/ryu/d2s.cpp
index 510b4b8aa3af6..e22bfa4a12e65 100644
--- a/libcxx/src/ryu/d2s.cpp
+++ b/libcxx/src/ryu/d2s.cpp
@@ -39,8 +39,8 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
-#include "charconv"
+#include <__config>
+#include <charconv>
#include "include/ryu/common.h"
#include "include/ryu/d2fixed.h"
diff --git a/libcxx/src/ryu/f2s.cpp b/libcxx/src/ryu/f2s.cpp
index 7e10b498367ef..e7d46d21cdbd8 100644
--- a/libcxx/src/ryu/f2s.cpp
+++ b/libcxx/src/ryu/f2s.cpp
@@ -39,8 +39,8 @@
// Avoid formatting to keep the changes with the original code minimal.
// clang-format off
-#include "__config"
-#include "charconv"
+#include <__config>
+#include <charconv>
#include "include/ryu/common.h"
#include "include/ryu/d2fixed.h"
diff --git a/libcxx/src/shared_mutex.cpp b/libcxx/src/shared_mutex.cpp
index 6a5a738a6762f..deb3ced014cad 100644
--- a/libcxx/src/shared_mutex.cpp
+++ b/libcxx/src/shared_mutex.cpp
@@ -6,12 +6,13 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
+#include <__config>
+
#ifndef _LIBCPP_HAS_NO_THREADS
-#include "shared_mutex"
+#include <shared_mutex>
#if defined(__ELF__) && defined(_LIBCPP_LINK_PTHREAD_LIB)
-#pragma comment(lib, "pthread")
+# pragma comment(lib, "pthread")
#endif
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/stdexcept.cpp b/libcxx/src/stdexcept.cpp
index b9c89703f3e88..d08b6740db1c3 100644
--- a/libcxx/src/stdexcept.cpp
+++ b/libcxx/src/stdexcept.cpp
@@ -6,11 +6,10 @@
//
//===----------------------------------------------------------------------===//
-#include "stdexcept"
-#include "new"
-#include "string"
-#include "system_error"
-
+#include <new>
+#include <stdexcept>
+#include <string>
+#include <system_error>
#ifdef _LIBCPP_ABI_VCRUNTIME
#include "support/runtime/stdexcept_vcruntime.ipp"
diff --git a/libcxx/src/string.cpp b/libcxx/src/string.cpp
index 3cde2e9005ba2..db7d7d5598dd8 100644
--- a/libcxx/src/string.cpp
+++ b/libcxx/src/string.cpp
@@ -6,17 +6,17 @@
//
//===----------------------------------------------------------------------===//
-#include "string"
-#include "charconv"
-#include "cstdlib"
-#include "cerrno"
-#include "limits"
-#include "stdexcept"
+#include <__debug>
+#include <cerrno>
+#include <charconv>
+#include <cstdlib>
+#include <limits>
+#include <stdexcept>
#include <stdio.h>
-#include "__debug"
+#include <string>
#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
-# include "cwchar"
+# include <cwchar>
#endif
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/strstream.cpp b/libcxx/src/strstream.cpp
index fe7e2d412065e..c3a7eb9a8c66d 100644
--- a/libcxx/src/strstream.cpp
+++ b/libcxx/src/strstream.cpp
@@ -7,13 +7,15 @@
//===----------------------------------------------------------------------===//
#include <__utility/unreachable.h>
-#include "strstream"
-#include "algorithm"
-#include "climits"
-#include "cstring"
-#include "cstdlib"
-#include "__debug"
-#include "__undef_macros"
+#include <__debug>
+#include <algorithm>
+#include <climits>
+#include <cstdlib>
+#include <cstring>
+#include <strstream>
+
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
_LIBCPP_BEGIN_NAMESPACE_STD
@@ -334,3 +336,5 @@ strstream::~strstream()
}
_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
diff --git a/libcxx/src/system_error.cpp b/libcxx/src/system_error.cpp
index 82472cbc84bff..1c4570291cb36 100644
--- a/libcxx/src/system_error.cpp
+++ b/libcxx/src/system_error.cpp
@@ -6,18 +6,17 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
-
-#include "system_error"
+#include <__config>
+#include <__debug>
+#include <cerrno>
+#include <cstdio>
+#include <cstdlib>
+#include <cstring>
+#include <string>
+#include <string.h>
+#include <system_error>
#include "include/config_elast.h"
-#include "cerrno"
-#include "cstring"
-#include "cstdio"
-#include "cstdlib"
-#include "string"
-#include "string.h"
-#include "__debug"
#if defined(__ANDROID__)
#include <android/api-level.h>
diff --git a/libcxx/src/thread.cpp b/libcxx/src/thread.cpp
index 8dddb240b5a07..0734659d2ddf2 100644
--- a/libcxx/src/thread.cpp
+++ b/libcxx/src/thread.cpp
@@ -6,14 +6,15 @@
//
//===----------------------------------------------------------------------===//
-#include "__config"
+#include <__config>
+
#ifndef _LIBCPP_HAS_NO_THREADS
-#include "thread"
-#include "exception"
-#include "vector"
-#include "future"
-#include "limits"
+#include <exception>
+#include <future>
+#include <limits>
+#include <thread>
+#include <vector>
#if __has_include(<unistd.h>)
# include <unistd.h> // for sysconf
diff --git a/libcxx/src/typeinfo.cpp b/libcxx/src/typeinfo.cpp
index 03eaad7dceb7f..c7f0a70f85c58 100644
--- a/libcxx/src/typeinfo.cpp
+++ b/libcxx/src/typeinfo.cpp
@@ -6,9 +6,10 @@
//
//===----------------------------------------------------------------------===//
-#include "typeinfo"
+#include <typeinfo>
#if defined(_LIBCPP_ABI_MICROSOFT) && !defined(_LIBCPP_ABI_VCRUNTIME)
+
#include <string.h>
int std::type_info::__compare(const type_info &__rhs) const noexcept {
diff --git a/libcxx/src/utility.cpp b/libcxx/src/utility.cpp
index 6d2cc4accee87..44433d11d7aa7 100644
--- a/libcxx/src/utility.cpp
+++ b/libcxx/src/utility.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "utility"
+#include <utility>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/valarray.cpp b/libcxx/src/valarray.cpp
index 5a3a869181c9a..5d63bc11846d5 100644
--- a/libcxx/src/valarray.cpp
+++ b/libcxx/src/valarray.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "valarray"
+#include <valarray>
_LIBCPP_BEGIN_NAMESPACE_STD
diff --git a/libcxx/src/variant.cpp b/libcxx/src/variant.cpp
index d38d3a799d32d..b6ec448081a9a 100644
--- a/libcxx/src/variant.cpp
+++ b/libcxx/src/variant.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "variant"
+#include <variant>
namespace std {
diff --git a/libcxx/src/vector.cpp b/libcxx/src/vector.cpp
index 201d4e3bf09a4..fa63d5c5e31c6 100644
--- a/libcxx/src/vector.cpp
+++ b/libcxx/src/vector.cpp
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
-#include "vector"
+#include <vector>
_LIBCPP_BEGIN_NAMESPACE_STD
More information about the libcxx-commits
mailing list