[libcxx-commits] [PATCH] D119667: [libc++] Granularize algorithm includes

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 14 08:41:20 PST 2022


Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for doing this! (It removes an item of my todo list :-) )
Two requests

1. mention in the commit message that this removes several includes that people accidentally depend on.  (in fact the addition in some headers show we already do this ourselves.) This isn't entirely obvious from the current message.
2. mention the changes in the release notes. @ldionne do you want one note or should we mention all includes we removed?

LGTM, I leave the final approval this first cleanup for @ldionne.



================
Comment at: libcxx/test/std/containers/sequences/list/list.ops/sort.pass.cpp:47
     c.sort();
     assert(distance(c.begin(), c.end()) == N);
 
----------------
Quuxplusone wrote:
> Could drive-by fix this to `std::distance` while you're here, if you like...
Slight preference to do that in a separate commit, just in case this one needs to be reverted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119667/new/

https://reviews.llvm.org/D119667



More information about the libcxx-commits mailing list