[libcxx-commits] [PATCH] D119667: [libc++] Granularize algorithm includes
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Feb 14 10:25:57 PST 2022
ldionne requested changes to this revision.
ldionne added a subscriber: libc++ vendors.
ldionne added a comment.
This revision now requires changes to proceed.
I am fine with this direction, however I agree CI should be green, and also we need to release-note this. I think the release note can only say that we removed transitive includes of `<algorithm>`, so if users see issues related to that, they know what the cause is. I don't think it's really useful to list all the headers that we removed `<algorithm>` *from*.
Requesting changes until those issues are fixed. Also, pinging libc++ vendors just so they are aware of this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119667/new/
https://reviews.llvm.org/D119667
More information about the libcxx-commits
mailing list