[libcxx-commits] [PATCH] D119667: [libc++] Granularize algorithm includes

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 13 08:21:11 PST 2022


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Seems fine to me if (1) CI is green and (2) we're all on board for breaking Hyrum's Law this month. I believe I've heard rumors to that effect — "it's very early in the 15.x release cycle, so let's remove all these redundant includes //now// and give people plenty of time to adjust and/or complain" — but I'll post in the Discord to get some nice explicit confirmation.



================
Comment at: libcxx/test/std/containers/sequences/list/list.ops/sort.pass.cpp:47
     c.sort();
     assert(distance(c.begin(), c.end()) == N);
 
----------------
Could drive-by fix this to `std::distance` while you're here, if you like...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119667/new/

https://reviews.llvm.org/D119667



More information about the libcxx-commits mailing list