[libcxx-commits] [PATCH] D118989: [libc++] __config cleanup; _LIBCPP_ABI_UNSTABLE should set _LIBCPP_ABI_VERSION

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D118989#3297171 <https://reviews.llvm.org/D118989#3297171>, @Quuxplusone wrote:

> Requesting changes just to make sure this gets attention.
> Skimming the existing code, it looks to me as if a vendor who compiles with `-D_LIBCPP_ABI_UNSTABLE -U_LIBCPP_ABI_VERSION` will currently get all their symbols in namespace `std::__1`. This PR changes that, so that they'll get all their symbols in namespace `std::__2` instead. I //suspect// this is not something we want to do, but ABI/vendor issues are above my pay grade, so I don't want to say I'm objecting to this. Just calling out a change that I think is //likely// to be significant.

I think if you compile with `_LIBCPP_ABI_UNSTABLE` you shouldn't have a problem with ABI changes. That's the entire point of using this macro. I might be wrong, but that's how I understand it. @ldionne should be able to clarify. We can of course also ask #libc_vendors <https://reviews.llvm.org/tag/libc_vendors/>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118989/new/

https://reviews.llvm.org/D118989