[libcxx-commits] [PATCH] D118989: [libc++] __config cleanup; _LIBCPP_ABI_UNSTABLE should set _LIBCPP_ABI_VERSION

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

This looks correct to me. I've actually wanted to get rid of `_LIBCPP_ABI_UNSTABLE` for a while, and I guess this is a great occasion to do this. Indeed, since this is the unstable ABI, we don't care about the namespace changing. If someone comes to this patch and they are broken by it, then they just figured out that they shouldn't be on the unstable ABI.

I'm not a big fan of mixing changes like this in the same commit, I'd have rather made all the NFC cleanups in one patch and then the ABI unstable change separately. But the patch itself is small enough, this is acceptable.

I'll follow-up with additional cleanups for the ABI macros, I've had something in mind for a while.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118989/new/

https://reviews.llvm.org/D118989