[libcxx-commits] [PATCH] D118989: [libc++] __config cleanup; _LIBCPP_ABI_UNSTABLE should set _LIBCPP_ABI_VERSION

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a comment.
This revision now requires changes to proceed.

Requesting changes just to make sure this gets attention.
Skimming the existing code, it looks to me as if a vendor who compiles with `-D_LIBCPP_ABI_UNSTABLE -U_LIBCPP_ABI_VERSION` will currently get all their symbols in namespace `std::__1`. This PR changes that, so that they'll get all their symbols in namespace `std::__2` instead. I //suspect// this is not something we want to do, but ABI/vendor issues are above my pay grade, so I don't want to say I'm objecting to this. Just calling out a change that I think is //likely// to be significant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118989/new/

https://reviews.llvm.org/D118989