[libcxx-commits] [PATCH] D131856: [libc++][NFC] Remove some of the code duplication in the string tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments.



================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_append/string.pass.cpp:59
 
 #if TEST_STD_VER > 3
   {   // LWG 2946
----------------
huixie90 wrote:
> In one place, I saw you changed from `> 3` to `>= 11`. To be consistent, either change this one too or revert the other change.
> I suppose this is checking the version is > Cxx03. I thought we need to use a different macro to check if the version is CXX03 in the non-test code and didn't know that this is working.
This is so weird, we should use `TEST_STD_VER >= 11` everywhere. I didn't know we had `TEST_STD_VER > 3` anywhere in the code base.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131856/new/

https://reviews.llvm.org/D131856