[libcxx-commits] [PATCH] D131856: [libc++][NFC] Remove some of the code duplication in the string tests

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 26 08:48:57 PDT 2022


philnik updated this revision to Diff 455931.
philnik marked 2 inline comments as done.
philnik added a comment.

- replace `> 3` with `>= 11` in the string tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131856/new/

https://reviews.llvm.org/D131856

Files:
  libcxx/test/std/strings/basic.string/string.access/at.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/back.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/front.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/index.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/clear.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/empty.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/length.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/max_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/over_max_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/reserve.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/reserve_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/resize_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/resize_size_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/shrink_to_fit.pass.cpp
  libcxx/test/std/strings/basic.string/string.capacity/size.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/char_assignment.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/copy_assignment.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/move_assignment.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/pointer_assignment.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/pointer_size_alloc.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view_assignment.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/T_size_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/pointer_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/size_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/string_size_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/string_view.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/T_size_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/pointer_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/rv_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/size_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/string_size_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/string_view.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_copy/copy.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_erase/iter.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_erase/iter_iter.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_erase/pop_back.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_erase/size_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_size_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/size_pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/size_size_char.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/size_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/string_view.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_op_plus_equal/pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_op_plus_equal/string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_replace/size_size_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_swap/swap.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/pointer_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/string_pointer.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/string_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/string_string_view.pass.cpp
  libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/string_view_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_compare/size_size_string.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_compare/string.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_find.first.not.of/string_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_find.first.of/string_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_find.last.not.of/string_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_find.last.of/string_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_find/string_size.pass.cpp
  libcxx/test/std/strings/basic.string/string.ops/string_rfind/string_size.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131856.455931.patch
Type: text/x-patch
Size: 272172 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220826/c0ed2f9e/attachment-0001.bin>


More information about the libcxx-commits mailing list