[libcxx-commits] [PATCH] D131856: [libc++][NFC] Remove some of the code duplication in the string tests

[Hui via Phabricator via libcxx-commits]

huixie90 accepted this revision as: huixie90.
huixie90 added a comment.

LGTM



================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_append/string.pass.cpp:59
 
 #if TEST_STD_VER > 3
   {   // LWG 2946
----------------
In one place, I saw you changed from `> 3` to `>= 11`. To be consistent, either change this one too or revert the other change.
I suppose this is checking the version is > Cxx03. I thought we need to use a different macro to check if the version is CXX03 in the non-test code and didn't know that this is working.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131856/new/

https://reviews.llvm.org/D131856