[libcxx-commits] [PATCH] D131498: [libc++][NFC] Rename the constexpr macros

Wed Aug 10 08:39:10 PDT 2022

philnik marked 2 inline comments as done.
philnik added inline comments.

================
Comment at: libcxx/.clang-format:18
+                  '_LIBCPP_CONSTEXPR_CXX20',
                   '_LIBCPP_CONSTEXPR_AFTER_CXX20',
                   '_LIBCPP_ALIGNOF',
----------------
Mordante wrote:
> philnik wrote:
> > avogelsgesang wrote:
> > > not sure what the outcome of the Discord discussion was (somehow I can't find the channel anymore?), but personally I would prefer to also change `_LIBCPP_CONSTEXPR_AFTER_CXX20` to `_LIBCPP_CONSTEXPR_CXX23`
> > > 
> > > Please don't let this stop you from merging your change though. It is a clear improvement compared to the previous state
> > Oops. We don't actually have a `_LIBCPP_CONSTEXPR_AFTER_CXX20` yet. Looks like I accidentally added it to the clang-format. I'll rename it when I commit the patch (assuming nobody requests further changes).
> Mainly curious can this be a regex?
The clang-format docs say that `AttributeMacros` is a `List of Strings`. So I don't think so. I've made a feature request [here](https://llvm.org/PR57054)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131498/new/

https://reviews.llvm.org/D131498