[libcxx-commits] [PATCH] D131498: [libc++][NFC] Rename the constexpr macros

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for working on this, it's great to have everything consistent in one go!
I have spot checked the changes, but I assume you used a tool to do the changes automatically.
LGTM, but I think it's good to get a few more explicit approvals so leave the final approval to somebody else.



================
Comment at: libcxx/.clang-format:18
+                  '_LIBCPP_CONSTEXPR_CXX20',
                   '_LIBCPP_CONSTEXPR_AFTER_CXX20',
                   '_LIBCPP_ALIGNOF',
----------------
philnik wrote:
> avogelsgesang wrote:
> > not sure what the outcome of the Discord discussion was (somehow I can't find the channel anymore?), but personally I would prefer to also change `_LIBCPP_CONSTEXPR_AFTER_CXX20` to `_LIBCPP_CONSTEXPR_CXX23`
> > 
> > Please don't let this stop you from merging your change though. It is a clear improvement compared to the previous state
> Oops. We don't actually have a `_LIBCPP_CONSTEXPR_AFTER_CXX20` yet. Looks like I accidentally added it to the clang-format. I'll rename it when I commit the patch (assuming nobody requests further changes).
Mainly curious can this be a regex?


================
Comment at: libcxx/test/libcxx/nasty_macros.compile.pass.cpp:146
+#define _LIBCPP_CONSTEXPR_AFTER_CXX14 NASTY_MACRO
+#define _LIBCPP_CONSTEXPR_AFTER_CXX17 NASTY_MACRO
+
----------------
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131498/new/

https://reviews.llvm.org/D131498