[libcxx-commits] [PATCH] D131498: [libc++][NFC] Rename the constexpr macros

Hui via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 11 15:38:05 PDT 2022


huixie90 added inline comments.


================
Comment at: libcxx/include/__config:835
 #  if _LIBCPP_STD_VER > 11
-#    define _LIBCPP_CONSTEXPR_AFTER_CXX11 constexpr
+#    define _LIBCPP_CONSTEXPR_CXX14 constexpr
 #  else
----------------
I am ok with the name in your patch. But have you considered
`_LIBCPP_CONSTEXPR_SINCE_CXX14`
The reason why I like this name is because in the synopsis it is exact these words "// constexpr since C++14"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131498/new/

https://reviews.llvm.org/D131498



More information about the libcxx-commits mailing list