[libcxx-commits] [PATCH] D103341: [libc++] Clean up test_iterators.h. NFCI.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 370743.
Quuxplusone retitled this revision from "[libcxx][nfc] Cleanup cpp20_input_iterator." to "[libc++] Clean up test_iterators.h. NFCI.".
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

> Are we doing this?

Basically nah; some of this has already been committed elsewhere (e.g. removing [[nodiscard]]) and the rest is not obviously good anymore.
But I've just done a new pass over test_iterators.h and recommend these new changes. There was a surprising amount of misindentation in ThrowingIterator!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103341/new/

https://reviews.llvm.org/D103341

Files:
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103341.370743.patch
Type: text/x-patch
Size: 33448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210904/f03e2113/attachment-0001.bin>