[libcxx-commits] [PATCH] D103341: [libc++] Clean up test_iterators.h. NFCI.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 371183.
Quuxplusone added a comment.

Oops, contiguous_iterator's `operator,` was already deleted (just not at the bottom of the class like the others).
Considered moving all the other iterators' operators into hidden friends (above their deleted `operator,`s), and then decided that that was too big an edit; might make that PR later. I don't immediately see why `random_access_iterator<T>` //should// be comparable to `random_access_iterator<U>`, but I could imagine us relying on that somehow in some test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103341/new/

https://reviews.llvm.org/D103341

Files:
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103341.371183.patch
Type: text/x-patch
Size: 33798 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210907/3f2e916c/attachment-0001.bin>