[libcxx-commits] [PATCH] D103341: [libc++] Clean up test_iterators.h. NFCI.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Sep 7 10:42:42 PDT 2021
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM when CI passes.
I'd rather keep the old formulations for operations in `ThrowingIterator`, but it's non-blocking.
================
Comment at: libcxx/test/support/test_iterators.h:567
ThrowingAction action_;
- mutable size_t index_;
+ mutable int index_;
};
----------------
I'd rather not make this change here and instead keep the previous formulations for `if (action_ == ...) if (index_ == 0) ...`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103341/new/
https://reviews.llvm.org/D103341
More information about the libcxx-commits
mailing list