[libcxx-commits] [PATCH] D112155: [runtimes] Remove FOO_TARGET_TRIPLE, FOO_SYSROOT and FOO_GCC_TOOLCHAIN

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

I went through my notes and the reason I introduced these flags was to support the scenario where you use `LLVM_ENABLE_PROJECTS=clang;libcxx;...` and you want to build libc++ (and other runtimes) for target other than host, so you cannot use `CMAKE_CXX_COMPILER_TARGET` or `CMAKE_SYSROOT` because that would also affect the tools build.

That predates the bootstrapping (née runtimes) build support and is very limited (you can only build runtimes for one target, you can only vary a few flags, you're still using the host compiler so you likely need a two-stage build) which is why we haven't used it ever since bootstrapping build became available.

I don't know if anyone still uses this support, but even if so we should steer them towards the bootstrapping build. I agree with @compnerd  that providing a deprecation message for now and removing them in the next release might be preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112155/new/

https://reviews.llvm.org/D112155