[libcxx-commits] [libcxx] 6b82adb - Raise compile error when using unimplemented functions

[Muiez Ahmed via libcxx-commits]

Author: Muiez Ahmed
Date: 2021-10-20T13:55:50-04:00
New Revision: 6b82adbb4980593f4661edf94e5539adfe1a9f4e

URL: https://github.com/llvm/llvm-project/commit/6b82adbb4980593f4661edf94e5539adfe1a9f4e
DIFF: https://github.com/llvm/llvm-project/commit/6b82adbb4980593f4661edf94e5539adfe1a9f4e.diff

LOG: Raise compile error when using unimplemented functions

The path functions in this patch are unimplemented (as per the TODO comment from upstream). To avoid running into a linker error (missing symbol), this patch raises a compile error by commenting out the functions, which is more user friendly.

Differential Revision: https://reviews.llvm.org/D111892

Added: 
    

Modified: 
    libcxx/include/filesystem

Removed: 
    


################################################################################
diff  --git a/libcxx/include/filesystem b/libcxx/include/filesystem
index 1fd77af99cc41..f99976f6cd7bd 100644
--- a/libcxx/include/filesystem
+++ b/libcxx/include/filesystem
@@ -966,6 +966,7 @@ public:
     _PathCVT<_ItVal>::__append_range(__pn_, __first, __last);
   }
 
+/*
 #if !defined(_LIBCPP_HAS_NO_LOCALIZATION)
   // TODO Implement locale conversions.
   template <class _Source, class = _EnableIfPathable<_Source, void> >
@@ -974,6 +975,7 @@ public:
   path(_InputIt __first, _InputIt _last, const locale& __loc,
        format = format::auto_format);
 #endif
+*/
 
   _LIBCPP_INLINE_VISIBILITY
   ~path() = default;