[libcxx-commits] [PATCH] D112155: [runtimes] Remove FOO_TARGET_TRIPLE, FOO_SYSROOT and FOO_GCC_TOOLCHAIN

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd accepted this revision.
compnerd added a comment.

I think that as long as the builders remain green, this is fine.  Yes, this is very likely to break users.  We should announce this change on llvm-dev at the very least, and you *could* possibly add a transition helper in the form of:

  if(NOT CMAKE_SYSROOT AND LIBCXX_SYSROOT)
    message(SEND_WARNING "LIBCXX_SYSROOT is deprecated, please use CMAKE_SYSROOT")
    set(CMAKE_SYSROOT ${LIBCXX_SYSROOT} CACHE STRING "" FORCE)
  endif()

I think that having a nice transition would be preferable, and we could drop it in the next release.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112155/new/

https://reviews.llvm.org/D112155