[libcxx-commits] [PATCH] D112012: [benchmarks] Unify libcxx's fork of google/benchmark to llvm/utils

Michael Kruse via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 18 23:13:51 PDT 2021


Meinersbur added a comment.

@ldionne What is your concrete proposal? Requiring Google Benchmark pre-installed on the host?

I think <root>/llvm is different in that it is not a subproject but contains core and supporting infrastructure (such as `<root>/llvm/cmake/Modules`, llvm-lit etc). Google Benchmark would be one of that. I don't think we should reject patches that just follow the status quo without having a plan what the future direction should be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012



More information about the libcxx-commits mailing list