[libcxx-commits] [PATCH] D112012: [benchmarks] Unify libcxx's fork of google/benchmark to llvm/utils

[Mircea Trofin via Phabricator via libcxx-commits]

mtrofin added a comment.

In D112012#3072064 <https://reviews.llvm.org/D112012#3072064>, @Meinersbur wrote:

> @ldionne What is your concrete proposal? Requiring Google Benchmark pre-installed on the host?
>
> I think <root>/llvm is different in that it is not a subproject but contains core and supporting infrastructure (such as `<root>/llvm/cmake/Modules`, llvm-lit etc). Google Benchmark would be one of that. I don't think we should reject patches that just follow the status quo without having a plan what the future direction should be.

@ldionne @Meinersbur  - trying to move this forward - if libcxx can't depend on llvm/ stuff, how about having a llvm/third-party common dir, would that work? (I'd want to circle this back to the thread discussing `google-benchmark` consolidation, but wanted to get a quick smoke test.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012