[libcxx-commits] [PATCH] D112012: [benchmarks] Unify libcxx's fork of google/benchmark to llvm/utils
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Oct 18 13:08:50 PDT 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
I like this a lot in spirit, thanks!
However, we are trying to decouple the runtimes (which include libc++) from everything in `<monorepo>/llvm`, and placing the GoogleBenchmark library inside `<monorepo>/llvm` somewhat goes against that. Would it make sense to try to find a place in LLVM where we can put third-party libraries like that? IMO it would be sensible to avoid tying them to `<monorepo>/llvm` just like we should avoid tying them to any other specific sub-project under the LLVM Foundation. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112012/new/
https://reviews.llvm.org/D112012
More information about the libcxx-commits
mailing list