[libcxx-commits] [PATCH] D111961: [libc++] Use addressof in vector.
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Oct 17 07:27:36 PDT 2021
Quuxplusone added a comment.
LprettyGTM! You'll need to `#include <__memory/addressof.h>` in at least one, maybe two, places, before CI will be happy.
================
Comment at: libcxx/include/vector:1740
+ _LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(_VSTD::addressof(__last)) == this,
"vector::erase(iterator, iterator) called with an iterator not"
" referring to this vector");
----------------
Pre-existing: `iterator, iterator` should be `iterator, iterator` (but that'll require updating tests, and should be a separate commit anyway)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111961/new/
https://reviews.llvm.org/D111961
More information about the libcxx-commits
mailing list