[libcxx-commits] [PATCH] D111961: [libc++] Use addressof in vector.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This addresses the usage of `operator&` in `<vector>`.

I now added tests for the current offending cases. I wonder whether it
would be better to add one addressof test per directory and test all
possible violations. Also to guard against possible future errors?

(Note there are still more headers with the same issue.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111961

Files:
  libcxx/include/__iterator/wrap_iter.h
  libcxx/include/vector
  libcxx/test/std/containers/sequences/vector/vector.cons/assign_move.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.cons/move.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/emplace.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter_iter.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_iter_iter.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_rvalue.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_size_value.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_value.addressof.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/vector.special/swap.addressof.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111961.380239.patch
Type: text/x-patch
Size: 17593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211017/492fd60c/attachment-0001.bin>