[libcxx-commits] [PATCH] D111961: [libc++] Use addressof in vector.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

> I now added tests for the current offending cases. I wonder whether it would be better to add one addressof test per directory and test all possible violations.

I won't say "no" to additional test coverage, but that sounds like a lot of work for not necessarily that much benefit. If you want to do it, then sure, but there will be a ton of stuff to check.

Whether or not we decide to expand the testing of `addressof`, I'm fine with this patch. Thanks for tackling this!

[needs CI to pass, as usual]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111961/new/

https://reviews.llvm.org/D111961