[libcxx-commits] [PATCH] D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++

[Sean via Phabricator via libcxx-commits]

SeanP added a comment.

@Quuxplusone what parts of this do you feel are unmaintainable?  We are open to ideas on how to address any concerns you have.

I see the changes break down into these groups:

- adding the namespace wrappers - these are simple additions that shouldn't impact anyone outside of z/OS
- platform specializations - these have #if's but always (except for two table definitions) occur within a block handling specialization for other platforms too
- code wrapped in _LIBCPP_ADDITIONAL_CHAR_ENCODING - I like the idea of moving these to separate files.  It was one alterative we considered
- error messages - yes these add a bunch of #if's.  This sounds like the code that alarmed you.  We have a better solution being worked on.  That solution replaces the string literals with passing an enum to a macro.  We can remove these changes and promote the new solution when ready.  The new solution gets rid of all of those #if's.

I really don't want to create a separate copy of the library as that will just be forking it.  We would rather point customers to one place to get their C++ library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111323/new/

https://reviews.llvm.org/D111323