[libcxx-commits] [PATCH] D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++

[Sean via Phabricator via libcxx-commits]

SeanP added inline comments.


================
Comment at: libcxx/docs/DesignDocs/MultipleCharEncodings.rst:89
+Enabling bimodal mode
+*********************
+
----------------
We have a better way of doing this that is being worked on now.

In a nutshell code like:

```
return string("The associated promise has been destructed prior "
                      "to the associated state becoming ready.");
```
will be replaced with:
```
return string(getMessage(_BROKEN_PROMISE));
```
and getMessage will expand out to an array of the strings index.

This will eliminate all of the #if's.  I also see a potential benefit that this could be the ground work for enabling internationalization of the runtime messages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111323/new/

https://reviews.llvm.org/D111323