[libcxx-commits] [PATCH] D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/filesystem:910
 #endif /* _LIBCPP_WIN32API */
+_LIBCPP_BEGIN_NAMESPACE_CES
 
----------------
My comment about "merely granularizing", concretely, would be something like "pull out lines 910–1518 into a new header, `libcxx/include/__filesystem/somemeaningfulname.h`," so that we didn't have headers that flipped back and forth between `CES` and non-`CES` "modes"; every header would be either all-under-`CES` or never-mention-`CES`.

I'm not saying that you clearly //should// do that granularizing. If ldionne or whoever didn't like that direction, or didn't like the PR regardless, then I admit it would be wasted work on your part. However, if you have the cycles to spare, I think it would be //at least, interesting// to see that approach proof-of-concepted.

Also, if you did that, then I bet you could make combined macros `_LIBCPP_BEGIN_NAMESPACE_STD_CES` and `_LIBCPP_END_NAMESPACE_STD_CES`, because you'd never be opening the `CES` namespace without also opening `_VSTD`. Right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111323/new/

https://reviews.llvm.org/D111323