[libcxx-commits] [PATCH] D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added inline comments.


================
Comment at: libcxxabi/include/zos/unwind.h:64
+void _Unwind_SetExceptionAddress(void *context, void *exception);
+unsigned int _Unwind_GetTypeSelector(void *context);
+void _Unwind_SetTypeSelector(void *context, unsigned int ttypeIndex);
----------------
If you are going to implement these, I highly recommend that you split the implementation from the main Itanium implementaion.

An ARM contributor has signed up the work to extract the ARM EH impl since it is so different.
I am feeling similarly for z/OS. Coupling z/OS specific logic makes the generic Itanium implementation much more difficult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99913/new/

https://reviews.llvm.org/D99913