[libcxx-commits] [PATCH] D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime

[Jonathan Crowther via Phabricator via libcxx-commits]

Jonathan.Crowther marked 5 inline comments as done.
Jonathan.Crowther added a comment.

> If you are going to implement these, I highly recommend that you split the implementation from the main Itanium implementaion.
>
> An ARM contributor has signed up the work to extract the ARM EH impl since it is so different.
> I am feeling similarly for z/OS. Coupling z/OS specific logic makes the generic Itanium implementation much more difficult.

We would like as best as possible to use the generic itanium implementation. To do so we will be revising our z/OS runtime to match the interfaces of Itanium . Once this is done I will be able to remove a large portion of the z/OS specific changes. I'll leave this patch inactive while we handle that on our end and I will ping once I have made the revisions.



================
Comment at: libcxxabi/include/zos/unwind.h:64
+void _Unwind_SetExceptionAddress(void *context, void *exception);
+unsigned int _Unwind_GetTypeSelector(void *context);
+void _Unwind_SetTypeSelector(void *context, unsigned int ttypeIndex);
----------------
MaskRay wrote:
> If you are going to implement these, I highly recommend that you split the implementation from the main Itanium implementaion.
> 
> An ARM contributor has signed up the work to extract the ARM EH impl since it is so different.
> I am feeling similarly for z/OS. Coupling z/OS specific logic makes the generic Itanium implementation much more difficult.
> If you are going to implement these, I highly recommend that you split the implementation from the main Itanium implementaion.
> 
> An ARM contributor has signed up the work to extract the ARM EH impl since it is so different.
> I am feeling similarly for z/OS. Coupling z/OS specific logic makes the generic Itanium implementation much more difficult.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99913/new/

https://reviews.llvm.org/D99913