[libcxx-commits] [PATCH] D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 12 13:15:59 PDT 2021


MaskRay added inline comments.


================
Comment at: libcxxabi/include/zos/unwind.h:50
+_Unwind_Reason_Code _Unwind_RaiseException( struct _Unwind_Exception *exception_object );
+void _Unwind_Resume (struct _Unwind_Exception *exception_object);
+void _Unwind_DeleteException (struct _Unwind_Exception *exception_object);
----------------
The LLVM coding standard doesn't add a space after the function name.


================
Comment at: libcxxabi/src/cxa_personality.cpp:605
     }
-    // Start scan by getting exception table address
-    const uint8_t *lsda = (const uint8_t *)_Unwind_GetLanguageSpecificData(context);
     if (lsda == 0)
     {
----------------
This is a regression on other platforms.
`results.languageSpecificData` is now nullptr.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99913/new/

https://reviews.llvm.org/D99913



More information about the libcxx-commits mailing list