[libcxx-commits] [libcxx] 4a0a85b - [libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-03-31T09:05:47+03:00
New Revision: 4a0a85becc9e19d288b5adcf713cb9e135c7f022

URL: https://github.com/llvm/llvm-project/commit/4a0a85becc9e19d288b5adcf713cb9e135c7f022
DIFF: https://github.com/llvm/llvm-project/commit/4a0a85becc9e19d288b5adcf713cb9e135c7f022.diff

LOG: [libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows

The tests expect that the <cuchar> include should fail. When libc++
is built on top of the MSVC runtime, the header does exist provided
by MSVC. Therefore, just mark the test as unsupported on windows,
to avoid tests that unexpectedly succeed.

Differential Revision: https://reviews.llvm.org/D99096

Added: 
    

Modified: 
    libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
    libcxx/test/std/strings/c.strings/cuchar.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp b/libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
index e14340a8e0f4..5ded5e70ba3f 100644
--- a/libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
+++ b/libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
@@ -8,6 +8,11 @@
 //
 // XFAIL: *
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// This should be removed once D97870 has landed.
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>

diff  --git a/libcxx/test/std/strings/c.strings/cuchar.pass.cpp b/libcxx/test/std/strings/c.strings/cuchar.pass.cpp
index 8fac63371c0b..ee436b5d06f7 100644
--- a/libcxx/test/std/strings/c.strings/cuchar.pass.cpp
+++ b/libcxx/test/std/strings/c.strings/cuchar.pass.cpp
@@ -8,6 +8,11 @@
 //
 // XFAIL: libc++
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// This should be removed once D97870 has landed.
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>