[libcxx-commits] [libcxx] 7acfd85 - [libcxx] [test] Don't add dirs from the LIB env var to PATH

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-03-31T09:05:47+03:00
New Revision: 7acfd85756736b2e240cc3a4ffd56f26d73ace9e

URL: https://github.com/llvm/llvm-project/commit/7acfd85756736b2e240cc3a4ffd56f26d73ace9e
DIFF: https://github.com/llvm/llvm-project/commit/7acfd85756736b2e240cc3a4ffd56f26d73ace9e.diff

LOG: [libcxx] [test] Don't add dirs from the LIB env var to PATH

The directories in LIB normally only contain import libraries or
static libraries, no runtime DLLs that would need to be found
while running tests.

This code stems from 1cd196e7b46e49d170a4b4013879a577dee59cb2,
which (among other things) tried to do this:

> * [Test] Fix handling of library runtime search paths by correctly adding them
>   to the PATH variable when running the tests.

It's unclear to me exactly what this fixed (or tried to) at the time,
as the LIB var doesn't normally point to runtime libs.

Differential Revision: https://reviews.llvm.org/D99241

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/config.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index 88527a49b686..11ebb914c90c 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -209,8 +209,6 @@ def _prefixed_env_list(var, prefix):
         flags = []
         compile_flags = []
         link_flags = _prefixed_env_list('LIB', '-L')
-        for path in _split_env_var('LIB'):
-            self.add_path(self.exec_env, path)
         return CXXCompiler(self, clang_path, flags=flags,
                            compile_flags=compile_flags,
                            link_flags=link_flags)